Inject Locale and TimeZone in ReceiptRenderer
#15759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/fix-hardware-test-ausralia
branch
from
52570a9 to
e3ddbb3
Compare
This decouples the tests from the location of the dev machine that runs them.
mokagio
force-pushed
the
mokagio/fix-hardware-test-ausralia
branch
from
e3ddbb3 to
25806b6
Compare
Collaborator
|
|
jaclync
approved these changes
Jun 17, 2025
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
Tests already passing locally (before and after), thanks for making them more resilient 
Comment on lines
+8
to
+9
| let locale = Locale(identifier: "en_US_POSIX") | ||
| let timeZone = TimeZone(secondsFromGMT: 0)! |
Contributor
There was a problem hiding this comment.
nit: these could be private
Suggested change
| let locale = Locale(identifier: "en_US_POSIX") | |
| let timeZone = TimeZone(secondsFromGMT: 0)! | |
| private let locale = Locale(identifier: "en_US_POSIX") | |
| private let timeZone = TimeZone(secondsFromGMT: 0)! |
|
|
||
| let renderer = ReceiptRenderer(content: content) | ||
|
|
||
| print(renderer.htmlContent()) |
Contributor
There was a problem hiding this comment.
good catch, looks like a debug print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working on simplifying hardware to be a Swift package, but the tests fail in CI, #15744
Investigating locally, I run into an unrelated test failure in
ReceiptRenderer.The reason it fails on my machine but not in CI is that the MD5 we check against was generated based on a different locale and time zone.
Once
LocaleandTimeZoneare made static in the tests, everything is green again.RELEASE-NOTES.txtif necessary. — N.A.